Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tile_size knob for winograd #3642. #8

Closed
wants to merge 1 commit into from
Closed

Add tile_size knob for winograd #3642. #8

wants to merge 1 commit into from

Conversation

cbalint13
Copy link

@cbalint13 cbalint13 commented Jul 28, 2019

This PR add extra tile_size field (knob option) for all winograd conv2d needed for apache/tvm#3642 .

Generated by upgrade script here .

@cbalint13
Copy link
Author

@merrymercy , @merrymercy , @kevinthesun , @FrozenGene

Please help with the review.

@merrymercy
Copy link
Collaborator

Please regenerate cuda_v0.05 because of #7

@cbalint13
Copy link
Author

Please regenerate cuda_v0.05 because of #7

@merrymercy ,

Rebased.

All entries are original as is plus tile_size field added and filled.


If online (jenkins) TVM test will fail with PR#3642 then:

  • My delay here was due to my investigation with one single failing (warning with 'cannot prove' during topi/tests on my pc/setup), so i prepared an exception and re-tuned this one.

  • I found a 22GFLOPS one (8k iteration) the original was 38GFLOPS (if computed "dry" just by timing numbers from json entries). Hope my replacement will be acceptable, but lets see if upstream jenkins fails or not (my pc/rk3399 does).

@cbalint13 cbalint13 closed this Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants