-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
output = model(features, adj) Are test features involved in the trainning process? #50
Comments
Although the model uses all data as input, it calculates loss only from idx_train which defined in load_data. |
@ChrisZhangcx |
You are right. It does seem like we combine the information of both train and test data. I try to think about this issue in a different way: we do need these edges in the adjacency matrix since our task is to give node representations according to each node's features as well as topology info of its neighbors. By removing the relation edges between the train and test nodes (by manually masking their edges in adjacency matrix), there might occur some of the following issues:
Thanks for your reply! I'm a starter in the graph network. Please let me know if you have any comments. |
@ChrisZhangcx |
Hello,tkipf !
Thanks for your share! In the trainng process,features are 2708 dims, does it involve test samples? thank you very much!
The text was updated successfully, but these errors were encountered: