Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better queue flushing #81

Open
tj opened this issue Jan 1, 2013 · 2 comments
Open

better queue flushing #81

tj opened this issue Jan 1, 2013 · 2 comments

Comments

@tj
Copy link
Owner

tj commented Jan 1, 2013

if a client is having a bad time we shouldn't be plastering it with a large queue on connection haha :D, this could easily lead to thrashing. normally this would "just work" but yeah not with node :(

@gjohnson
Copy link
Collaborator

gjohnson commented Jan 1, 2013

Yeah... I am assuming you are referring actually handling pause() and resume(), etc. instead of just checking if sock.writable. I would only imagine we'd have to go removeListener 7 ways to sunday on various emitters, etc... add timeouts for the resume events... ALOT more code haha...

@tj
Copy link
Owner Author

tj commented Jan 1, 2013

yeah haha we'd have to actually check all the write()s to see if they're flushing to the kernel buffer and all that crap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants