-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tags to support Go modules #23
Comments
Setting GO111MODULE=off is the obvious solution, but I'd rather avoid polluting my GOPATH. I will try with a temporary GOPATH for now. |
I appear to have successfully done this by running That command added To "pin" that version (I am also vendoring) I also added a We also have a "tools.go" file as described on the modules wiki. // +build tools
package grpc
import (
// We are using 3.0.0 tag of this dependency, but the convention of using a
// versioned path like "github.com/tiziano88/elm-protobuf/v3" doesn't work.
// This is expected since it is not (yet?) a proper go module. This is
// exacerbated by an old "v0.0.4" tag in the repository, which the go tools
// incorrectly recognize as a pre-release module tag.
//
// Instead, there is a replace directive in the go.mod file to pin the
// correct module incompatible version.
_ "github.com/tiziano88/elm-protobuf/protoc-gen-elm"
) I think the newer tags are in the format they are in for the sake of the elm packaging tools. Maybe dual tags are needed? But a Isn't it funny how Elm packages are to Elm modules the same way go modules are to go packages? 😆 |
Thanks for the comments, I have not been following the latest on Go module management, if anyone wants to suggest a fix I am happy to implement it! |
There may be a workaround, but I'm having a lot of trouble trying to install latest due to the current tags lacking the "v" prefix.
The text was updated successfully, but these errors were encountered: