Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install blocks #1857

Closed
db39 opened this issue Nov 15, 2024 · 0 comments · Fixed by #1858
Closed

Fix install blocks #1857

db39 opened this issue Nov 15, 2024 · 0 comments · Fixed by #1858
Assignees
@db39
Labels
bug Something isn't working

Comments

@db39
Copy link
Contributor

db39 commented Nov 15, 2024

Our install blocks don't block installation on some configurations (64-bit devices) when they should.
@db39 db39 added the bug Something isn't working label Nov 15, 2024
@db39 db39 self-assigned this Nov 15, 2024
@db39 db39 linked a pull request Nov 15, 2024 that will close this issue
Fix install blocks #1858
Merged
This was referenced Nov 15, 2024
Merged
Open
db39 added a commit that referenced this issue Nov 28, 2024
@db39
Fix install blocks (#1858)
f127ad2 
Resolves #1857

This change refactors our installation blocks to use single conditions,
fixing a bug when checking for Raspbian-based systems that allowed
installations to proceed on 64-bit systems regardless of the OS version.

This also adds a check for a `FORCE_INSTALL` flag - setting the
`FORCE_INSTALL` environment variable allows you to bypass the system
checks to attempt an install on unsupported systems.

<a data-ca-tag
href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1858"><img
src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review
on CodeApprove" /></a>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@db39 db39

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix install blocks tiny-pilot/tinypilot
1 participant
@db39