Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to run a single playwright test #1696

Closed
mtlynch opened this issue Nov 30, 2023 · 0 comments · Fixed by #1768
Closed

Make it easier to run a single playwright test #1696

mtlynch opened this issue Nov 30, 2023 · 0 comments · Fixed by #1768
Assignees
@jdeanwallace
Labels
enhancement New feature or request small

Comments

@mtlynch
Copy link
Contributor

mtlynch commented Nov 30, 2023

Related: #1694

We originally designed the run-e2e-tests script so that the caller could pass Playwright command-line flags, and the script would pass them through to Playwright, so you could do this:

./dev-scripts/run-e2e-tests --grep 'shows privacy policy'

And then the script would launch Playwright with:

npx playwright test --grep 'shows privacy policy'

We lost this functionality as part of https://github.com/tiny-pilot/tinypilot-pro/pull/851

Now that we're writing more e2e tests, it would be handy if the run-e2e-tests script made it easier for us to pick out specific tests to run from our suite.
@mtlynch mtlynch added enhancement New feature or request small labels Nov 30, 2023
@jdeanwallace jdeanwallace self-assigned this Mar 31, 2024
@jdeanwallace jdeanwallace mentioned this issue Mar 31, 2024
Merged
jdeanwallace added a commit that referenced this issue Apr 2, 2024
@jdeanwallace
Allow for extra Playwright CLI options when running e2e tests (#1768)
aa9bd31 
Resolves #1696

This PR allows for extra Playwright CLI options to passed to Playwright
when running e2e tests.

For example, this means you can guide Playwright on which tests to run
like so:
```bash
./dev-scripts/run-e2e-tests -- --grep 'shows privacy policy'
```

<a data-ca-tag
href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1768"><img
src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review
on CodeApprove" /></a>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdeanwallace jdeanwallace

Labels
enhancement New feature or request small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow for extra Playwright CLI options when running e2e tests tiny-pilot/tinypilot
2 participants
@jdeanwallace @mtlynch