Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute type information as PEP 561 describes #22

Open
fjcuadrado opened this issue Oct 24, 2023 · 3 comments
Open

Distribute type information as PEP 561 describes #22

fjcuadrado opened this issue Oct 24, 2023 · 3 comments
Labels

Comments

@fjcuadrado
Copy link

Help us help you

I'm using tink-py in one of my projects with, what it can be called, a modern development environment that includes Python type annotations and mypy, as the static type checker. As I can see, tink code has type annotations but it doesn't distribute them so mypy could use them (as PEP 561 describes).

What sort of feature would you like to see?

Tink should distribute type information as PEP 561 or as mypy suggests in the following link:

https://mypy.readthedocs.io/en/stable/installed_packages.html

Have you considered any alternative solutions?

I configure mypy to ignore missing import errors from tink module.

Thank you so much.

Regards.

@juergw
Copy link
Contributor

juergw commented Oct 31, 2023

Thanks for this suggestion. I agree that we should do this.

@juergw juergw self-assigned this Oct 31, 2023
@juergw
Copy link
Contributor

juergw commented Nov 27, 2023

In our tests, we are using pytype and not mypy. pytype is less strict. I tried to use mypy, and I got some errors that first would need to be resolved. We first need resolve these errors before we can add this annotation.

@juergw
Copy link
Contributor

juergw commented Nov 27, 2023

I don't have time to work on this at the moment.

@juergw juergw removed their assignment Nov 27, 2023
@juergw juergw added the p3 label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants