diff --git a/eslint.config.mjs b/eslint.config.mjs index caf6c01a4f230..ea65d380b63d0 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -112,6 +112,7 @@ export default [ "perfectionist/sort-named-exports": "error", "unicorn/no-abusive-eslint-disable": "error", "unicorn/no-array-push-push": "error", + "unicorn/no-console-spaces": "error", "unicorn/no-instanceof-array": "error", "unicorn/no-invalid-remove-event-listener": "error", "unicorn/no-new-buffer": "error", diff --git a/test/downloadutils.mjs b/test/downloadutils.mjs index 682e916e320f7..6d80e2153f425 100644 --- a/test/downloadutils.mjs +++ b/test/downloadutils.mjs @@ -86,7 +86,7 @@ async function downloadManifestFiles(manifest) { try { await downloadFile(file, url); } catch (ex) { - console.error(`Error during downloading of ${url}: ${ex}`); + console.error(`Error during downloading of ${url}:`, ex); fs.writeFileSync(file, ""); // making it empty file fs.writeFileSync(`${file}.error`, ex); } diff --git a/test/driver.js b/test/driver.js index 75bc8a9164225..15c6c5952ceb3 100644 --- a/test/driver.js +++ b/test/driver.js @@ -1192,7 +1192,7 @@ class Driver { resolve(); }) .catch(reason => { - console.warn(`Driver._send failed (${url}): ${reason}`); + console.warn(`Driver._send failed (${url}):`, reason); this.inFlightRequests--; resolve(); diff --git a/test/unit/testreporter.js b/test/unit/testreporter.js index 05abc51847961..4c5b6b8905798 100644 --- a/test/unit/testreporter.js +++ b/test/unit/testreporter.js @@ -18,7 +18,7 @@ const TestReporter = function (browser) { resolve(); }) .catch(reason => { - console.warn(`TestReporter - send failed (${action}): ${reason}`); + console.warn(`TestReporter - send failed (${action}):`, reason); resolve(); send(action, json); diff --git a/web/app.js b/web/app.js index e45c954b97048..5ea10fcfde157 100644 --- a/web/app.js +++ b/web/app.js @@ -204,7 +204,7 @@ const PDFViewerApplication = { try { await this.preferences.initializedPromise; } catch (ex) { - console.error(`initialize: "${ex.message}".`); + console.error("initialize:", ex); } if (AppOptions.get("pdfBugEnabled")) { await this._parseHashParams(); @@ -308,7 +308,7 @@ const PDFViewerApplication = { await __non_webpack_import__(PDFWorker.workerSrc); } } catch (ex) { - console.error(`_parseHashParams: "${ex.message}".`); + console.error("_parseHashParams:", ex); } } if (params.has("textlayer")) { @@ -324,7 +324,7 @@ const PDFViewerApplication = { await loadPDFBug(); this._PDFBug.loadCSS(); } catch (ex) { - console.error(`_parseHashParams: "${ex.message}".`); + console.error("_parseHashParams:", ex); } break; } @@ -337,7 +337,7 @@ const PDFViewerApplication = { await loadPDFBug(); this._PDFBug.init(mainContainer, enabled); } catch (ex) { - console.error(`_parseHashParams: "${ex.message}".`); + console.error("_parseHashParams:", ex); } } // It is not possible to change locale for the (various) extension builds. @@ -1128,7 +1128,7 @@ const PDFViewerApplication = { this.downloadManager.download(data, this._downloadUrl, this._docFilename); } catch (reason) { // When the PDF document isn't ready, fallback to a "regular" download. - console.error(`Error when saving the document: ${reason.message}`); + console.error(`Error when saving the document:`, reason); await this.download(); } finally { await this.pdfScriptingManager.dispatchDidSave(); diff --git a/web/download_manager.js b/web/download_manager.js index 255806f039837..26d6200b3cbed 100644 --- a/web/download_manager.js +++ b/web/download_manager.js @@ -93,7 +93,7 @@ class DownloadManager { window.open(viewerUrl); return true; } catch (ex) { - console.error(`openOrDownloadData: ${ex}`); + console.error("openOrDownloadData:", ex); // Release the `blobUrl`, since opening it failed, and fallback to // downloading the PDF file. URL.revokeObjectURL(blobUrl); diff --git a/web/firefoxcom.js b/web/firefoxcom.js index f8e711686b998..5b98d17a60683 100644 --- a/web/firefoxcom.js +++ b/web/firefoxcom.js @@ -121,7 +121,7 @@ class DownloadManager { window.open(viewerUrl); return true; } catch (ex) { - console.error(`openOrDownloadData: ${ex}`); + console.error("openOrDownloadData:", ex); // Release the `blobUrl`, since opening it failed, and fallback to // downloading the PDF file. URL.revokeObjectURL(blobUrl); diff --git a/web/l10n.js b/web/l10n.js index 053614e9885c7..ad469a5266be6 100644 --- a/web/l10n.js +++ b/web/l10n.js @@ -85,7 +85,7 @@ class L10n { try { await this.#l10n.translateElements([element]); } catch (ex) { - console.error(`translateOnce: "${ex}".`); + console.error("translateOnce:", ex); } } diff --git a/web/pdf_page_view.js b/web/pdf_page_view.js index 46ab525a0e002..13b18e433c26f 100644 --- a/web/pdf_page_view.js +++ b/web/pdf_page_view.js @@ -402,7 +402,7 @@ class PDFPageView { "display" ); } catch (ex) { - console.error(`#renderAnnotationLayer: "${ex}".`); + console.error("#renderAnnotationLayer:", ex); error = ex; } finally { this.#dispatchLayerRendered("annotationlayerrendered", error); @@ -414,7 +414,7 @@ class PDFPageView { try { await this.annotationEditorLayer.render(this.viewport, "display"); } catch (ex) { - console.error(`#renderAnnotationEditorLayer: "${ex}".`); + console.error("#renderAnnotationEditorLayer:", ex); error = ex; } finally { this.#dispatchLayerRendered("annotationeditorlayerrendered", error); @@ -425,7 +425,7 @@ class PDFPageView { try { await this.drawLayer.render("display"); } catch (ex) { - console.error(`#renderDrawLayer: "${ex}".`); + console.error("#renderDrawLayer:", ex); } } @@ -441,7 +441,7 @@ class PDFPageView { this.#buildXfaTextContentItems(result.textDivs); } } catch (ex) { - console.error(`#renderXfaLayer: "${ex}".`); + console.error("#renderXfaLayer:", ex); error = ex; } finally { if (this.xfaLayer?.div) { @@ -466,7 +466,7 @@ class PDFPageView { if (ex instanceof AbortException) { return; } - console.error(`#renderTextLayer: "${ex}".`); + console.error("#renderTextLayer:", ex); error = ex; } this.#dispatchLayerRendered("textlayerrendered", error); diff --git a/web/pdf_rendering_queue.js b/web/pdf_rendering_queue.js index 60e885e225c4c..620eae6c104da 100644 --- a/web/pdf_rendering_queue.js +++ b/web/pdf_rendering_queue.js @@ -201,7 +201,7 @@ class PDFRenderingQueue { if (reason instanceof RenderingCancelledException) { return; } - console.error(`renderView: "${reason}"`); + console.error("renderView:", reason); }); break; } diff --git a/web/pdf_scripting_manager.js b/web/pdf_scripting_manager.js index 63d08c60459ef..402613f87f507 100644 --- a/web/pdf_scripting_manager.js +++ b/web/pdf_scripting_manager.js @@ -105,7 +105,7 @@ class PDFScriptingManager { try { this.#scripting = this.#initScripting(); } catch (error) { - console.error(`setDocument: "${error.message}".`); + console.error("setDocument:", error); await this.#destroyScripting(); return; @@ -192,7 +192,7 @@ class PDFScriptingManager { eventBus.dispatch("sandboxcreated", { source: this }); } catch (error) { - console.error(`setDocument: "${error.message}".`); + console.error("setDocument:", error); await this.#destroyScripting(); return; diff --git a/web/viewer.js b/web/viewer.js index 4cab203081f10..7924d850e10ba 100644 --- a/web/viewer.js +++ b/web/viewer.js @@ -254,7 +254,7 @@ function webViewerLoad() { } catch (ex) { // The viewer could be in e.g. a cross-origin