Skip to content

Commit

Permalink
Upgrade eslint-plugin-perfectionist to version 4.2.0
Browse files Browse the repository at this point in the history
This requires two changes on our side:

- The order of exports in `web/viewer{-geckoview}.js` changes slightly
  because `eslint-plugin-perfectionist` aligned the sorting order with
  the `eslint-plugin-sort-experts` plugin we used before. This restores
  the change from commit 347f155.
- The `eslint-plugin-import` plugin contains a bug that causes the new
  version of `eslint-plugin-perfectionist` to be reported as unresolved.
  This issue is tracked upstream, and since the plugin works fine we
  can simply extend the ignore list we already have to avoid this error
  until the upstream bug is fixed.
  • Loading branch information
timvandermeij committed Dec 7, 2024
1 parent 7d1ca73 commit 7ca9fa1
Show file tree
Hide file tree
Showing 5 changed files with 66 additions and 88 deletions.
2 changes: 2 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ export default [
"web",
"fluent-bundle",
"fluent-dom",
// See https://github.com/firebase/firebase-admin-node/discussions/1359.
"eslint-plugin-perfectionist",
],
},
],
Expand Down
146 changes: 61 additions & 85 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"eslint-plugin-jasmine": "^4.2.2",
"eslint-plugin-json": "^4.0.1",
"eslint-plugin-no-unsanitized": "^4.1.2",
"eslint-plugin-perfectionist": "^3.9.1",
"eslint-plugin-perfectionist": "^4.2.0",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-unicorn": "^56.0.1",
"globals": "^15.13.0",
Expand Down
2 changes: 1 addition & 1 deletion web/viewer-geckoview.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ if (
}

export {
PDFViewerApplication,
AppConstants as PDFViewerApplicationConstants,
AppOptions as PDFViewerApplicationOptions,
PDFViewerApplication,
};
2 changes: 1 addition & 1 deletion web/viewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ if (
}

export {
PDFViewerApplication,
AppConstants as PDFViewerApplicationConstants,
AppOptions as PDFViewerApplicationOptions,
PDFViewerApplication,
};

0 comments on commit 7ca9fa1

Please sign in to comment.