Merge pull request mozilla#18510 from timvandermeij/findbar-button

Improve how the findbar's toggle button is referenced in the viewer code
timvandermeij · Jul 29, 2024 · 7199c96 · 7199c96
2 parents 45e42cc + f430a6b
commit 7199c96
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/web/app.js b/web/app.js
@@ -717,7 +717,7 @@ const PDFViewerApplication = {
     }
 
     if (this.supportsIntegratedFind) {
-      appConfig.toolbar?.viewFind?.classList.add("hidden");
+      appConfig.findBar?.toggleButton?.classList.add("hidden");
     }
 
     if (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) {

diff --git a/web/toolbar.js b/web/toolbar.js
@@ -38,7 +38,6 @@ import {
  * @property {HTMLButtonElement} next - Button to go to the next page.
  * @property {HTMLButtonElement} zoomIn - Button to zoom in the pages.
  * @property {HTMLButtonElement} zoomOut - Button to zoom out the pages.
- * @property {HTMLButtonElement} viewFind - Button to open find bar.
  * @property {HTMLButtonElement} editorFreeTextButton - Button to switch to
  *   FreeText editing.
  * @property {HTMLButtonElement} download - Button to download the document.

diff --git a/web/viewer.js b/web/viewer.js
@@ -49,7 +49,6 @@ function getViewerConfiguration() {
       next: document.getElementById("next"),
       zoomIn: document.getElementById("zoomIn"),
       zoomOut: document.getElementById("zoomOut"),
-      viewFind: document.getElementById("viewFind"),
       print: document.getElementById("print"),
       editorFreeTextButton: document.getElementById("editorFreeText"),
       editorFreeTextParamsToolbar: document.getElementById(