From d293048c5dd8baba9411a65276f50ce44c6fb2b1 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Fri, 27 Oct 2023 14:55:12 +0200
Subject: [PATCH] Pause translation when appending the textLayer and
 structTreeLayer to the page

Note that we must append the textLayer to the DOM *before* enabling the `highlighter` and `accessibilityManager`, to avoid breaking e.g. a pending searching operation.
The least invasive solution, that I was able to come up with, is to introduce a new `TextLayerBuilder` callback-function for this purpose.
---
 web/pdf_page_view.js      | 10 +++++++++-
 web/text_layer_builder.js | 14 +++++++++++---
 2 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/web/pdf_page_view.js b/web/pdf_page_view.js
index d59d14fa97851..41cc54ce4b546 100644
--- a/web/pdf_page_view.js
+++ b/web/pdf_page_view.js
@@ -436,7 +436,10 @@ class PDFPageView {
       : null);
     const treeDom = this.structTreeLayer?.render(tree);
     if (treeDom) {
+      // Pause translation when inserting the structTree in the DOM.
+      this.l10n.pause();
       this.canvas?.append(treeDom);
+      this.l10n.resume();
     }
     this.structTreeLayer?.show();
   }
@@ -863,7 +866,12 @@ class PDFPageView {
         enablePermissions:
           this.#textLayerMode === TextLayerMode.ENABLE_PERMISSIONS,
       });
-      div.append(this.textLayer.div);
+      this.textLayer.onAppend = textLayerDiv => {
+        // Pause translation when inserting the textLayer in the DOM.
+        this.l10n.pause();
+        this.div.append(textLayerDiv);
+        this.l10n.resume();
+      };
     }
 
     if (
diff --git a/web/text_layer_builder.js b/web/text_layer_builder.js
index e9db36e949bf1..d22ce6cc4f604 100644
--- a/web/text_layer_builder.js
+++ b/web/text_layer_builder.js
@@ -62,9 +62,14 @@ class TextLayerBuilder {
     this.isOffscreenCanvasSupported = isOffscreenCanvasSupported;
     this.#enablePermissions = enablePermissions === true;
 
+    /**
+     * Callback used to attach the textLayer to the DOM.
+     * @type {function}
+     */
+    this.onAppend = null;
+
     this.div = document.createElement("div");
     this.div.className = "textLayer";
-    this.hide();
   }
 
   #finishRendering() {
@@ -131,12 +136,15 @@ class TextLayerBuilder {
     this.#finishRendering();
     this.#scale = scale;
     this.#rotation = rotation;
-    this.show();
+    // Ensure that the textLayer is appended to the DOM *before* handling
+    // e.g. a pending search operation.
+    this.onAppend(this.div);
+    this.highlighter?.enable();
     this.accessibilityManager?.enable();
   }
 
   hide() {
-    if (!this.div.hidden) {
+    if (!this.div.hidden && this.renderingDone) {
       // We turn off the highlighter in order to avoid to scroll into view an
       // element of the text layer which could be hidden.
       this.highlighter?.disable();