Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno build? #185

Closed
unicomp21 opened this issue Nov 2, 2021 · 9 comments
Closed

Deno build? #185

unicomp21 opened this issue Nov 2, 2021 · 9 comments

Comments

@unicomp21
Copy link

No description provided.

@timostamm
Copy link
Owner

Do you know what is required to support Deno?

@unicomp21
Copy link
Author

@timostamm
Copy link
Owner

No. Have you actually tried running protobuf-ts with Deno?

What failed specifically, and how do you propose to solve it? If Deno requires special code paths, how do we ensure they continue to function as the code base moves along?

@unicomp21
Copy link
Author

As an aside, the nats client support for Deno, might be a good template.

https://github.com/nats-io/nats.js/search?l=Markdown&q=deno

@unicomp21
Copy link
Author

If Deno requires special code paths, how do we ensure they continue to function as the code base moves along?
Tests?

@timostamm
Copy link
Owner

Tests?

Would you like to contribute them?

@unicomp21
Copy link
Author

unicomp21 commented Nov 5, 2021

Maybe, looks like the codegen will need to change for both cases. Thinking it over.

@timostamm
Copy link
Owner

Please reopen if there are any news. For a start, we'd need to know what exactly fails to run with Deno.

@QuantumGhost
Copy link

QuantumGhost commented Aug 22, 2022

I'm trying to use protobuf-ts with Deno.

I have tried to import @protobuf-ts/runtime directly in Deno with esm.sh. However, since the import statements in generated code have no .ts extension and Deno not allowing import without filename extension, I cannot import the generated code in Deno.

Example

What's expected:

The generated import statements have .ts extension, for example:

import { Hat } from "./service-twirp-example.ts";
import { Size } from "./service-twirp-example.ts";

I think #233 may help this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants