Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync code from ClickHouse/clickhouse-connect #66

Open
jovezhong opened this issue Dec 21, 2024 · 1 comment
Open

Sync code from ClickHouse/clickhouse-connect #66

jovezhong opened this issue Dec 21, 2024 · 1 comment
Assignees

Comments

@jovezhong
Copy link
Collaborator

https://github.com/ClickHouse/clickhouse-connect is the Python lib for ClickHouse
I guess it was renamed and refactored.

I am trying to port the latest clickhouse dbt plugin https://github.com/ClickHouse/dbt-clickhouse to Timeplus, but that code requires clickhouse_connect. There is no easy way to change the lib name to make it work, since many function calls in clickhouse_connect and this proton-python are different.

I would suggest updating this repo to sync the code from clickhouse-connect. If that'll create too many breaking change, maybe create a new timeplus-py-connect repo

@jovezhong
Copy link
Collaborator Author

I created a fork at https://github.com/timeplus-io/timeplus-connect
It seems that the proton-driver was forked from a community-driven Python lib for ClickHouse, based on TCP. https://github.com/ClickHouse/clickhouse-connect is a new Python lib created and maintained by ClickHouse team, using HTTP port for maximum compatibility, and other tools in the Python ecosystem are based on the clickhouse-connect, such as dbt/dlt/superset. Please work on https://github.com/timeplus-io/timeplus-connect to let it support timeplusd and Proton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants