Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

JSON view overrides response content #202

Open
jebbdomingo opened this issue Jul 23, 2019 · 0 comments · May be fixed by #203
Open

JSON view overrides response content #202

jebbdomingo opened this issue Jul 23, 2019 · 0 comments · May be fixed by #203
Assignees
@jebbdomingo
Labels
bug
Milestone
3.1

Comments

@jebbdomingo
Copy link
Contributor

Response's content in controller-level is always overridden in JSON view, see

kodekit/code/view/json.php

Line 177 in 8b9048f

$context->content = $output;

@jebbdomingo jebbdomingo added this to the 3.0.0-beta.2 milestone Jul 23, 2019
@jebbdomingo jebbdomingo self-assigned this Jul 23, 2019
jebbdomingo added a commit that referenced this issue Jul 23, 2019
@jebbdomingo
#202 Do not override existing content
877bd5b
@jebbdomingo jebbdomingo linked a pull request Jul 23, 2019 that will close this issue
Open
ercanozkaya added a commit that referenced this issue Jul 26, 2019
@ercanozkaya
#202: Use view content if it is set explicitly
59f2c25
@amazeika amazeika modified the milestones: 3.0.0-beta.2, 3.0.0 Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jebbdomingo jebbdomingo

Labels
bug
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

JSON view overrides response content timble/kodekit
2 participants
@amazeika @jebbdomingo