store_command: propagate the error code to the root command #8798
Conversation
Signed-off-by: Boyang Lyu <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
Hi @JackL9u. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
the
size/S
| } | ||
| // delete store by its ID | ||
| prefix := fmt.Sprintf(storePrefix, id) | ||
| _, err := doRequest(cmd, prefix, http.MethodDelete, http.Header{}) | ||
| if err != nil { | ||
| cmd.Printf("Failed to delete store %s: %s\n", args[0], err) | ||
| return | ||
| return fmt.Errorf("failed to delete store") |
There was a problem hiding this comment.
It will be better to keep the id and error.
Signed-off-by: Boyang Lyu <[email protected]>
Signed-off-by: Boyang Lyu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8798 +/- ##
==========================================
- Coverage 75.80% 75.76% -0.04%
==========================================
Files 461 461
Lines 72315 72316 +1
==========================================
- Hits 54817 54791 -26
- Misses 14000 14031 +31
+ Partials 3498 3494 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Boyang Lyu <[email protected]>
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nolouch, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
ti-chi-bot
bot
added
ok-to-test
|
/retest |
What problem does this PR solve?
propagate the error code to the root command, fixing the bug mention in issue 8762
Issue Number: Ref #8762
What is changed and how does it work?
Check List
Tests
The normal case worked.
The interactive case also works.
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note