store_command: propagate the error code to the root command #8795
Conversation
Signed-off-by: Boyang Lyu <[email protected]>
Signed-off-by: Boyang Lyu <[email protected]>
ti-chi-bot
bot
added
the
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @JackL9u. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
needs-ok-to-test
| } | ||
| // delete store by its ID | ||
| prefix := fmt.Sprintf(storePrefix, id) | ||
| _, err := doRequest(cmd, prefix, http.MethodDelete, http.Header{}) | ||
| if err != nil { | ||
| cmd.Printf("Failed to delete store %s: %s\n", args[0], err) | ||
| return | ||
| return fmt.Errorf("Failed to delete store.") |
There was a problem hiding this comment.
How about keeping the old message？
Signed-off-by: Boyang Lyu <[email protected]>
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
What problem does this PR solve?
propagate the error code to the root command, fixing the bug mention in issue 8762
Issue Number: Ref #8762
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note