Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource-group:fix issue that the deleted resource group still appear in metrics #8722

Merged
merged 3 commits into from
Oct 18, 2024
Merged

resource-group:fix issue that the deleted resource group still appear in metrics #8722

merged 3 commits into from
Oct 18, 2024

Conversation

AndreMouche
Copy link
Member

@AndreMouche AndreMouche commented Oct 16, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #8716

What is changed and how does it work?

resource-group: fix issue that the deleted resource group still appear in metrics

Check List

Release note

resource-group: fix issue that the deleted resource group still appear in metrics

@AndreMouche
resourcemanager/server/manager.go:fix issue that the deleted resource…
f3777ef 
…-gruop still appear in metrics

Signed-off-by: AndreMouche <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-linked-issue dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2024
@AndreMouche AndreMouche added the affects-8.1 This bug affects the 8.1.x(LTS) versions. label Oct 16, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.93%. Comparing base (26123dc) to head (f805f98).
Report is 70 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8722      +/-   ##
==========================================
- Coverage   71.70%   69.93%   -1.77%     
==========================================
  Files         517      517              
  Lines       67466    79947   +12481     
==========================================
+ Hits        48375    55914    +7539     
- Misses      15520    20454    +4934     
- Partials     3571     3579       +8
Flag Coverage Δ
unittests 69.93% <0.00%> (-1.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 16, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 16, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-16 07:45:27.907620193 +0000 UTC m=+429925.056530370: ☑️ agreed by lhy1024.
  • 2024-10-16 10:09:24.863165152 +0000 UTC m=+438562.012074984: ☑️ agreed by okJiang.

@lhy1024
Copy link
Contributor

lhy1024 commented Oct 16, 2024

/check-issue-triage-complete

1 similar comment
@okJiang
Copy link
Member

okJiang commented Oct 17, 2024

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot merged commit 41bd2cd into tikv:master Oct 18, 2024
22 of 25 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Dec 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8899.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 11, 2024
Merged
ti-chi-bot bot added a commit that referenced this pull request Dec 12, 2024
@ti-chi-bot @AndreMouche @ti-chi-bot
resource-group:fix issue that the deleted resource group still appear…
860a6b6 
… in metrics (#8722) (#8899)

close #8716

resource-group: fix issue that the deleted resource group still appear in metrics

Signed-off-by: AndreMouche <[email protected]>

Co-authored-by: AndreMouche <[email protected]>
Co-authored-by: Shirly <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okJiang okJiang okJiang approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
affects-8.1 This bug affects the 8.1.x(LTS) versions. approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resource-control:deleted-resource group still appear in available RU pannel
4 participants
@AndreMouche @lhy1024 @okJiang @ti-chi-bot