Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with Django 3.1 #25

Open
sanjioh opened this issue Feb 12, 2021 · 2 comments · May be fixed by #26
Open

Compatibility with Django 3.1 #25

sanjioh opened this issue Feb 12, 2021 · 2 comments · May be fixed by #26

Comments

@sanjioh
Copy link

sanjioh commented Feb 12, 2021

Hello,

thanks for maintaining django-jet2!

I'd like to report a compatibility issue I experienced upgrading a project to Django 3.1.
It looks like something goes wrong with fieldset rendering:

Django 3.0

Screen_Shot_2021-02-11_at_15 46 30

Django 3.1

Screen_Shot_2021-02-11_at_15 51 42

Screen_Shot_2021-02-11_at_15 52 02

Any chance this can get fixed?

Please let me know if I can be of further help.

Thanks,

Fabio
xrmx added a commit to xrmx/django-jet2 that referenced this issue Feb 24, 2021
@xrmx
js: fixup gettext in django 3.1
c6396f6 
For some reason in Django 3.1 django.gettext is not available anymore in the scope,
it's available as window.gettext though. Update translate.js to work
with both locations.

This was already reported here:
geex-arts#149

Fix tikservices#25
@xrmx xrmx linked a pull request Feb 24, 2021 that will close this issue
Open
@marcoooo
Copy link

marcoooo commented Apr 9, 2021

Hi @xrmx I've just created this new fork: https://github.com/marcoooo/django-jet2 where I just pushed updates on js libs, including your latest updates. If by chance you still wanna play with it :-)

@xrmx
Copy link

xrmx commented Apr 9, 2021

@marcoooo See if you find something useful there too https://github.com/appli-intramuros/django-jet/pulls . That specific fork may have some useful javascript frontend changes.

xrmx added a commit to djungle-io/django-djet2 that referenced this issue May 18, 2022
@xrmx
js: fixup gettext in django 3.1
fe3b755 
For some reason in Django 3.1 django.gettext is not available anymore in the scope,
it's available as window.gettext though. Update translate.js to work
with both locations.

This was already reported here:
geex-arts#149

Fix tikservices#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

js: fixup gettext in django 3.1 xrmx/django-jet2
3 participants
@xrmx @marcoooo @sanjioh