Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(velodyne_msgs): change xml version 3.0 to 1.0 #82

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(velodyne_msgs): change xml version 3.0 to 1.0 #82

merged 1 commit into from
Oct 4, 2023

Conversation

KhalilSelyan
Copy link
Contributor

PR Type

  • Bug Fix

Related Links

#71

Description

The XML version on this file has a typo, it should be 1.0 instead of 3.0

Review Procedure

Confirm correct change

Remarks

Pre-Review Checklist for the PR Author

  • [x ] Assign PR to reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@KhalilSelyan KhalilSelyan marked this pull request as draft October 4, 2023 08:10
@KhalilSelyan KhalilSelyan marked this pull request as ready for review October 4, 2023 08:11
@KhalilSelyan
Copy link
Contributor Author

@mitsudome-r Opened PR to fix the xml version we talked about before

@mebasoglu mebasoglu changed the title fix xml version 3.0 -> 1.0 fix(velodyne_msgs): change xml version 3.0 to 1.0 Oct 4, 2023
drwnz
drwnz approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwnz drwnz merged commit 74cdda4 into tier4:main Oct 4, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwnz drwnz drwnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KhalilSelyan @drwnz