Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(velodyne): reset pointcloud correctly, including width and height fields #216

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Nov 5, 2024

PR Type

  • Bug Fix

Related Links

Description

Velodyne decoders were resetting only the point buffer but not the width/height header fields, resulting in an invalid pointcloud output when no valid points have been received in a scan.

This PR uses the correct reset method to fix this problem.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.38%. Comparing base (a908f61) to head (501355f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   26.16%   26.38%   +0.21%     
==========================================
  Files          99       99              
  Lines        9198     9112      -86     
  Branches     2215     2187      -28     
==========================================
- Hits         2407     2404       -3     
+ Misses       6401     6319      -82     
+ Partials      390      389       -1     
Flag Coverage Δ
differential 26.38% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@zusizusi zusizusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
this branch worked on lsim.

Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mojomex mojomex merged commit 24ace12 into tier4:main Nov 5, 2024
12 checks passed
@mojomex mojomex deleted the fix/velodyne-reset-pointcloud branch November 5, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants