Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create .codecov.yml and move ignored directories there #200

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Sep 26, 2024

PR Type

  • Improvement

Related Links

Improves this PR:

Description

Create a .codecov.yml file as recommended in CodeCov's documentation and move the excluded directory settings there. This allows for more flexibility and hopefully once and for all excluded nebula_examples from coverage too.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex
Copy link
Collaborator Author

mojomex commented Sep 26, 2024

CI config is valid, merging.

@mojomex mojomex merged commit 9f706e3 into tier4:main Sep 26, 2024
10 checks passed
@mojomex mojomex deleted the chore/codecov-yaml-file branch September 26, 2024 10:03
@mojomex
Copy link
Collaborator Author

mojomex commented Sep 26, 2024

It worked, nebula_examples is now gone:
image
CodeCov report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant