revert: "fix: correct azimuth offset" #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5e587ba.
|
@amc-nu I'm sorry for this. Could you quick approve this revert. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=========================================
+ Coverage 4.81% 11.41% +6.59%
=========================================
Files 249 68 -181
Lines 19204 7177 -12027
Branches 1075 1016 -59
=========================================
- Hits 925 819 -106
+ Misses 17579 5678 -11901
+ Partials 700 680 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amc-nu
approved these changes
Mar 29, 2024
badai-nguyen
changed the title
badai-nguyen
changed the title
|
@drwnz It seems I need your approve to merge this Revert PR. Could you approve this? |
|
@badai-nguyen |
|
@knzo25 Thanks, but I still cannot merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #112
Since some strange pointcloud appear after merged as pointed here. I revert this PR and will investigate more detail to fix the azimuth correction issue.