Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nebula streams start before ros finishes its setup #237

Open
knzo25 opened this issue Nov 26, 2024 · 1 comment
Open

nebula streams start before ros finishes its setup #237

knzo25 opened this issue Nov 26, 2024 · 1 comment

Comments

@knzo25
Copy link
Collaborator

knzo25 commented Nov 26, 2024

Mainly in setups with a higher number of sensors, we have observed that sometimes autoware's containers (the ones that include nebula) die during startup, usually in the constructor.
Due to how ROS loads containers as libraries sequentially, I believe we should wait until ROS has finished its setup before starting the driver's streams.

This may be related to #181

@drwnz @mojomex

@mojomex
Copy link
Collaborator

mojomex commented Nov 26, 2024

I totally agree. To do this properly, we should be refactoring to use lifecycle nodes. I know that using a one-off ROS2 timer has been proposed as a quick solution, which would work (init code only runs once ROS2 executor starts spinning). While we can do this as a temporary measure, I would like to kick off a discussion in the Autoware forums on startup sequences, lifecycles, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants