From 2fcfef10ab41eb8d1e0924e50b26784e8bd956d1 Mon Sep 17 00:00:00 2001 From: Maximilian Schmeller Date: Thu, 28 Dec 2023 14:30:10 +0900 Subject: [PATCH] chore(robosense): remove todos for reading return mode from DIFOP config file can be used as well, for now. Once setting return modes becomes possible (robosense publishes communication API for sensor) this must be revised --- .../nebula_decoders_robosense/decoders/bpearl_v4.hpp | 2 +- .../nebula_decoders_robosense/decoders/helios.hpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/nebula_decoders/include/nebula_decoders/nebula_decoders_robosense/decoders/bpearl_v4.hpp b/nebula_decoders/include/nebula_decoders/nebula_decoders_robosense/decoders/bpearl_v4.hpp index f283a7f8c..9dba88d9b 100644 --- a/nebula_decoders/include/nebula_decoders/nebula_decoders_robosense/decoders/bpearl_v4.hpp +++ b/nebula_decoders/include/nebula_decoders/nebula_decoders_robosense/decoders/bpearl_v4.hpp @@ -241,7 +241,7 @@ class BpearlV4 : public SensorBase, ReturnMode getReturnMode( const packet_t & /* packet */, const SensorConfigurationBase & config) const override { - return config.return_mode; // TODO(mojomex): add DIFOP packet handling back in + return config.return_mode; } }; diff --git a/nebula_decoders/include/nebula_decoders/nebula_decoders_robosense/decoders/helios.hpp b/nebula_decoders/include/nebula_decoders/nebula_decoders_robosense/decoders/helios.hpp index 24c40a2d5..29bccfcff 100644 --- a/nebula_decoders/include/nebula_decoders/nebula_decoders_robosense/decoders/helios.hpp +++ b/nebula_decoders/include/nebula_decoders/nebula_decoders_robosense/decoders/helios.hpp @@ -298,7 +298,7 @@ class Helios ReturnMode getReturnMode( const packet_t & /* packet */, const SensorConfigurationBase & config) const override { - return config.return_mode; // TODO(mojomex): add DIFOP packet handling back in + return config.return_mode; } };