Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configuration sim_time converter #536

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

xygyo77
Copy link
Contributor

@xygyo77 xygyo77 commented Oct 7, 2024

Description

If there is no time MSG in the processing time of the target object, use all time MSGs to configure the sim_time converter

Related links

https://tier4.atlassian.net/browse/RT2-1881

Notes for reviewers

In caret_report, no warning messages or other logs from caret_analyze are displayed.

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • (Optional) The PR has been properly tested with CARET_report verification.
  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…use all time MSGs to configure the sim_time converter

Signed-off-by: ISP akm <[email protected]>
@xygyo77 xygyo77 requested a review from ymski October 7, 2024 08:04
Signed-off-by: ISP akm <[email protected]>
Signed-off-by: ISP akm <[email protected]>
@ymski
Copy link
Contributor

ymski commented Oct 9, 2024

@xygyo77
With this modification, the process may differ depending on the input.
Please add a test to verify that the new processing details are being executed correctly.

Signed-off-by: ISP akm <[email protected]>
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymski ymski requested a review from miyakoshi-dev October 9, 2024 05:19
Copy link
Contributor

@miyakoshi-dev miyakoshi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[compare] ========== Result ==========
[compare] 1/3 file existence matches
[compare] OK. file existence matches
[compare] 2/3 yaml files
[compare] OK. yaml matches
[compare] 3/3 PNG files
[compare] OK. PNG matches
[compare] ====== ALL OK ==============
LGTM

@xygyo77 xygyo77 merged commit 6689150 into tier4:main Oct 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants