-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tune_bayes does not finalize by itself #752
Comments
Thanks for the issue! I don't have access to your |
It isn't specific to my particular workflow or dataset; here's a simple example library(tidymodels)
library(xgboost)
mtcars <- mtcars %>% mutate(mpg = factor(mpg))
split <- initial_validation_split(mtcars)
rset <- validation_set(split)
bt_mod <- boost_tree("classification", mtry=tune())
bt_wf <- workflow() %>%
add_model(bt_mod) %>%
add_recipe(recipe(mpg ~ ., data=mtcars))
bt_wf %>% tune_grid(resamples=rset)
# i Creating pre-processing data to finalize unknown parameter: mtry
bt_wf %>% tune_bayes(resamples=rset)
# Error in `dials::grid_latin_hypercube()`:
# ! These arguments contain unknowns: `mtry`.
# ℹ See the `finalize()` function. |
Even if one passes the
This is quite relevant, because to solve it one has to "manually" update the parameter space or to create the grid. |
any update on this? |
tune_grid
is able to finalizemtry()
itself, buttune_bayes
fails withAnd I do not know what to pass to
param_info
, because?parameters
is lacking (tidymodels/dials#313).I found an example online using
extract_parameter_set_dials(bt_mod) %>% finalize(comb4_sample)
, but this is not mentioned anywhere in?tune_bayes
or?finalize
.Even if I change the model to not tune
mtry()
, I still get the mysterious errorThe text was updated successfully, but these errors were encountered: