Skip to content
This repository has been archived by the owner on Nov 26, 2018. It is now read-only.

"Go" / "Log in" / and "Done" for signing into the notes app is redundant #78

Open
skrugman opened this issue May 5, 2014 · 7 comments

Comments

@skrugman
Copy link

skrugman commented May 5, 2014

"Go" in the keyboard doesn't do anything. "Done" minimizes the keyboard. and Log in is what we actually want - to log in.

Can we get rid of the "Done" and make the "go" a "Done" that minimizes the keyboard?

photo 2

@skrugman skrugman changed the title Simpligy the "Go" / "Log in" / and "Done" for signing into the notes app "Go" / "Log in" / and "Done" for signing into the notes app is redundant May 5, 2014
@kentquirk kentquirk reopened this May 5, 2014
@skrugman
Copy link
Author

skrugman commented May 5, 2014

In communication with Nico about it. There must be a way...

On Mon, May 5, 2014 at 6:18 PM, Kent Quirk [email protected] wrote:

Reopened #78 #78.


Reply to this email directly or view it on GitHubhttps://github.com//issues/78#event-117893998
.

@nicolashery
Copy link

Hum, yeah I'm afraid Kent is right. But that is the keyboard iOS shows when there is a form with submit.

It's not that bad actually, what I'm going to fix is that when you hit "Go" (equivalent to hitting "Enter" on the desktop), it actually logs you in.

@kentquirk
Copy link
Contributor

Sorry, I was a bit fumble-fingered there. Because we're not building a native app yet, we have limited control over the behavior of the iOS-standard things. But I'm glad to hear we can at least trap the Go button.

@skrugman
Copy link
Author

skrugman commented May 5, 2014

What about the "done" - thats not a standard is it?

On Mon, May 5, 2014 at 6:55 PM, Nicolas Hery [email protected]:

Hum, yeah I'm afraid Kent is right. But that is the keyboard iOS shows
when there is a form with submit.

It's not that bad actually, what I'm going to fix is that when you hit
"Go" (equivalent to hitting "Enter" on the desktop), it actually logs you
in.


Reply to this email directly or view it on GitHubhttps://github.com//issues/78#issuecomment-42209847
.

@nicolashery
Copy link

I think it is @skrugman, sorry. I'll see when I get to fixing the "Go" button if there is anything we can do...

@cmakler
Copy link

cmakler commented May 6, 2014

@jh-bate
Copy link

jh-bate commented May 7, 2014

@nicolashery with PR tidepool-org/clamshell#25 I changed the Login to be an actual button which might go part way to resolving this issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants