Skip to content

Commit

Permalink
OvmfPkg/Library/HardwareInfoLib: Fix memory allocation at PciHostBrid…
Browse files Browse the repository at this point in the history
…geUtilityGetRootBridgesHostProvided

Currently, PciHostBridgeUtilityGetRootBridgesHostProvided allocates memory for aperture structures without clearing memory. This causes garbage in the Translation field, but the Base and Limit fields have the correct values because they are copied from the HOST_BRIDGE_INFO fields in the HardwareInfoPciHostBridgeHostBridgeHostBridgeGetApertures function.

RootBridge: PciRoot(0x0)
  Support/Attr: 70069 / 70069
    DmaAbove4G: No
NoExtConfSpace: No
     AllocAttr: 3 (CombineMemPMem Mem64Decode)
           Bus: 0 - 80 Translation=0
            Io: 6000 - FFFF Translation=5E9EB018
           Mem: 80000000 - DFFFFFFF Translation=0
    MemAbove4G: 600000000000 - 7FFFFFFFFFFF Translation=0
          PMem: FFFFFFFFFFFFFFFF - 0 Translation=0
   PMemAbove4G: FFFFFFFFFFFFFFFF - 0 Translation=0

Cc: Alexander Graf <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Signed-off-by: Alexander Gryanko [email protected]
  • Loading branch information
Alexander Gryanko committed Oct 5, 2024
1 parent 80d9b44 commit 9e172c0
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,12 @@ PciHostBridgeUtilityGetRootBridgesHostProvided (
PCI_ROOT_BRIDGE_APERTURE PMem;
PCI_ROOT_BRIDGE_APERTURE PMemAbove4G;

ZeroMem (&Io, sizeof (Io));
ZeroMem (&Mem, sizeof (Mem));
ZeroMem (&MemAbove4G, sizeof (MemAbove4G));
ZeroMem (&PMem, sizeof (PMem));
ZeroMem (&PMemAbove4G, sizeof (PMemAbove4G));

//
// Initialize the Hardware Info list head to start with an empty but valid
// list head.
Expand Down

0 comments on commit 9e172c0

Please sign in to comment.