Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash if preconditioner is set to PcNone in 3d #4

Open
alexus37 opened this issue Nov 26, 2020 · 3 comments
Open

Crash if preconditioner is set to PcNone in 3d #4

alexus37 opened this issue Nov 26, 2020 · 3 comments

Comments

@alexus37
Copy link

I am trying to use the solvePressure function without a Preconditioner (PcNone or 0).

solvePressure(
                    flags=flags,
                    vel=velocity,
                    pressure=pressure,
                    cgAccuracy=1e-6,
                    cgMaxIterFac=6000 / self.opt.res,
                    retRhs=rhs,
                    preconditioner=0,
                )

I think the error is in source/plugin/pressure.cpp#L407. I would make a PR to fix it, but only if this repo is active and someone is going to look at it :D

@sebbas
Copy link
Contributor

sebbas commented Nov 26, 2020

Yes, the assert in setICPreconditioner() cannot handle PC_None. This should be fixed in the develop branch first (not on Github) which then could be merged back into this repositories master branch.

@alexus37
Copy link
Author

okay, I guess then my hands are tied.

@sebbas
Copy link
Contributor

sebbas commented Nov 26, 2020

Bug reports are still welcome! If you already have a patch you could attach it to this report. It could still be committed on your behalf, just not as a Github PR.

@alexus37 alexus37 changed the title Crash is preconditioner is set to PcNone in 3d Crash if preconditioner is set to PcNone in 3d Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants