Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for customizing scss #271

Open
tommyalatalo opened this issue May 14, 2022 · 6 comments
Open

Improve docs for customizing scss #271

tommyalatalo opened this issue May 14, 2022 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@tommyalatalo
Copy link

The documentation for customizing scss is lacking, the entirety of the documentation is literally Set variables in ./assets/scss/common/_variables.scss. This is not enough to make sense of what to do.

I've created the _variables.scss file above and entered there variables into it. I would expect the button on the landing page to have black text after doing this, but nothing changes at all.

$color-btn-bg: #000000
$color-btn-text: #000000

These variables don't seem to be in the files when cloning the child version of the theme (which I thought would include "changing colors" in "minor customization"), I had to find the above variables in the doks main repo, there they are defined in assets/scss/components/_buttons.scss. Why does my variable settings not change anything? Did I do something wrong, or is setting variables in ./assets/scss/common/_variables.scss actually not enough?

@h-enk h-enk self-assigned this May 17, 2022
@h-enk h-enk added the documentation Improvements or additions to documentation label May 17, 2022
@h-enk
Copy link
Member

h-enk commented May 17, 2022

Totally agree (and you're not the first to point this out). So, I will definitely write a guide for this + get back to you on your specific issue.

@h-enk h-enk transferred this issue from thuliteio/doks May 18, 2022
@h-enk h-enk added this to the v0.4.3 milestone May 18, 2022
@jlarfors
Copy link

@h-enk any progress on this? I also cannot customise the child theme, after trying the _variables.scss.

If you want a test repository, here's mine based on the child theme: https://github.com/verifa/terraplate/blob/0dda47ae53728ab96fb161bb69ca674ad43b1f0c/site/assets/scss/common/_variables.scss

I'd be happy to help with whatever I can but the issue is my lack of knowledge with the setup, and the idea behind Doks and child theme is that I wouldn't have to learn too much :)

@olblak
Copy link

olblak commented Aug 16, 2022

Hi,
I recently switched to the child theme as well for better maintainability and I would be very interested to find a way to change the primary color as I did.
Would you have any hints to share?
Like the files which need to be copy from start theme?

@h-enk h-enk pinned this issue Aug 18, 2022
@ChristopherRemde
Copy link

Hey! I was just wondering if there have been any updates to this? I'd also love to change the primary colors on the website, but this issue still seems to be there in the newest version.

@h-enk
Copy link
Member

h-enk commented Jun 2, 2023

Hey, thanks for nudging 😉 Doks v1.0.0-beta.2 will be available soon! Then I'll migrate getdoks.org itself to this version and will update the content for v1 — including a guide to update the color scheme

@ChristopherRemde
Copy link

Super cool, can't wait :)

@h-enk h-enk unpinned this issue Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants