Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent saving old pin #693

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Prevent saving old pin #693

merged 3 commits into from
Nov 21, 2024

Conversation

zaelgohary
Copy link
Contributor

Changes

  • Added a new state for which is used whenever the user tries to set new pin that matches the old one.

Related issue:

#630

Tested Scenarios:

  • write wrong old pin
  • normal scenario
  • set new pin same as old
  • set new pin diff than old then the confirm w a diff pin

@zaelgohary zaelgohary merged commit 5842a27 into development Nov 21, 2024
1 check failed
@zaelgohary zaelgohary deleted the development_fix_pin branch November 21, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaelgohary @AhmedHanafy725