Fix: CapRover Dashboard App: Details of Workers disappear after few seconds #3363
Conversation
…-sdk-ts into development_caprover
- Send the both of the deployments, leader and workers. - Call the 'getGrafanaUrl' on mounting the component.
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
- Enhanced Deletion Dialog: displays all attached workers in the deletion dialog to prompt user confirmation before proceeding. - Worker Deletion Logic: Iterates through the machine's interface, extracts the associated worker nodes, and deletes them efficiently. - Refactored Delete Function: Improved the delete function.
- Used the some() method since it'll be faster than the `filter` method. - Update the checker to check if the selected items have workers.
Mahmoud-Emad
force-pushed
the
development_caprover
branch
from
ba1df10
to
0f1d968
Compare
This happened because the worker is listed instead of the master, which is wrong |
- Push the master into the first index of the result array - Push the workers into the master, second index of the result array - Tested the code well
This issue isn't related to my PR, it could be another issue, it says there is another network workload with the same name already exists. |
|
Workers are being showed as leaders in contracts page.
|
|
I deleted the caprover deployment but 1 network contract still exist after deletion. Happened more than once.
|
@zaelgohary In the contracts, all the cluster's workers carry the same name as the cluster (which is the leader name) so we can list them as part of the cluster |
It's a known issue i think #3425 |
It's not. It was fixed in #3456 which was merged yesterday. Can you merge development to your branch? and if the issue still exist, we can open an issue for it as this only happen in Caprover. |
|
The issue is already solved yeah, I just noticed that I have to build the client first
However, yeah one contract still exists and should be deleted! |
|
I deployed a new instance & whenever I view its details I get the following error:
I also got the same error when deleting a worker. |
|
I tried adding workers most of the times it passed, but it failed once. Deletion works fine |
…-sdk-ts into development_caprover
- Ensure that workers are correctly removed from the deployment list when the leader is deleted to maintain data integrity. - Merged the latest changes from the development branch to keep the codebase up to date. - Conducted thorough testing to verify the complete functionality and ensure no regressions were introduced. Test Scenarios 1. Deploy `leader`, and `worker`, Go go to the contracts page and delete the deployed `leader`. 2. Deploy `leader`, attach a `worker` to it then delete the whole cluster just in time without refreshing the page. 3. Deploy `leader`, and `worker`, delete the deployed `worker` and attach another, then delete the whole cluster just in time without refreshing the page. 4. Deploy a cluster with 1 leader and 2 workers check the deployment listing dialog and make sure all of them are listed 3. Delete a cluster with the leader and more than 3 workers and make sure all of them are deleted. PS: Make sure no errors on the Caprover listing page.
Description
Fix listing Caprover workers
Changes
Test Scenarios
leader, andworker, Go go to the contracts page and delete the deployedleader.leader, attach aworkerto it then delete the whole cluster just in time without refreshing the page.leader, andworker, delete the deployedworkerand attach another, then delete the whole cluster just in time without refreshing the page.PS: Make sure no errors on the Caprover listing page.
Related Issues
Screenshots/Videos
Screencast.from.09-03-2024.05.27.14.PM.webm
Checklist