-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic synchronous API for triggering reconcilation runs #42
Labels
Comments
chadlwilson
added a commit
that referenced
this issue
Oct 25, 2021
Currently directly serializes the returns the `MigrationRun` which is probably not desirable.
chadlwilson
added a commit
that referenced
this issue
Oct 25, 2021
chadlwilson
added a commit
that referenced
this issue
Oct 25, 2021
chadlwilson
added a commit
that referenced
this issue
Oct 25, 2021
Believe this is more canonical usage anyway.
chadlwilson
added a commit
that referenced
this issue
Oct 25, 2021
chadlwilson
added a commit
that referenced
this issue
Oct 25, 2021
Needs more work, however start to decouple the persisted results model from the returned model.
Basic API added. Paths need changing, but runs can be triggered with
Returning {
"completedDurationSeconds": 2.7854958,
"completedTime": "2021-10-25T14:30:10.290869700Z",
"createdTime": "2021-10-25T14:30:07.505373900Z",
"datasetId": "test-dataset",
"id": 29,
"results": {
"sourceRows": 1003,
"targetRows": 1003
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context / Goal
To support performance testing it would be useful to have a basic API to trigger a reconcilation run, and wait for it to be complete.
This way, when implementing #26 we can use simple timed HTTP calls. Ideally the response can tell us various timings that we can use for reporting purposes.
Expected Outcome
Out of Scope
Additional context / implementation notes
The text was updated successfully, but these errors were encountered: