Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes to template issues for new users using the template #25

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

pacospace
Copy link
Contributor

Signed-off-by: Francesco Murdaca [email protected]

Related Issues and Dependencies

Related-To: thoth-station/support#91

@pacospace pacospace requested review from goern, fridex and harshad16 and removed request for goern October 14, 2021 10:05
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2021
@sesheta sesheta requested a review from KPostOffice October 14, 2021 10:06
@pacospace pacospace force-pushed the add-notes branch 2 times, most recently from 9ef699e to fafebc5 Compare October 14, 2021 10:16
Signed-off-by: Francesco Murdaca <[email protected]>
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

@sesheta
Copy link
Member

sesheta commented Oct 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2021
@sesheta sesheta merged commit 991eb54 into thoth-station:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants