Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helium: transport properties not implemented #5

Open
thorade opened this issue Jan 2, 2013 · 4 comments
Open

Helium: transport properties not implemented #5

thorade opened this issue Jan 2, 2013 · 4 comments

Comments

@thorade
Copy link
Owner

thorade commented Jan 2, 2013

Helium does currently use transport properties of Butane!
Instead, it should use the special helium correlations, but these are not yet implemented.

@thorade
Copy link
Owner Author

thorade commented Sep 19, 2014

Comment by @casella:
Dynamic viscosity in the Helium model doesn't work, looking at the implementation it seems that the "right" coefficients are missing from the table (only integer numbers show up in the code)

thorade added a commit that referenced this issue Oct 8, 2014
added helium viscosity, thermal conductivity will come later
@thorade
Copy link
Owner Author

thorade commented Oct 8, 2014

@casella Helium viscosity is now implemented, using the same special hardcoded algorithm as in RefProp. Results have been manualy tested (~20 points) to be identical, you are invited to do further testing.
Thermal conductivity will come later.

@casella
Copy link

casella commented Oct 8, 2014

Thank you Matthis!

We plan to use your model for a library on which we'll be going to
publish extensively. Can you point me out the correct citations for your
library?

        Francesco

@thorade
Copy link
Owner Author

thorade commented Oct 8, 2014

You are welcome! Feel free to submit more issues if there is anything that could be improved. Also, if speed is an issue, I could try working on that.
The github repository lists some publications that you could cite:
https://github.com/thorade/HelmholtzMedia#library-description

  • The Modelica 2012 conference paper could be seen as the official publication,
  • the publication in Environmental Earth Sciences describes some details related to derivatives, index reduction and root finding,
  • and then finally my PhD thesis sums up the content from all other publications - it will be published as OpenAccess later this year.

thorade added a commit that referenced this issue Oct 10, 2014
thorade added a commit that referenced this issue Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants