Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugging of Ancillary.density_pT_Soave #3

Open
thorade opened this issue Nov 20, 2012 · 4 comments
Open

debugging of Ancillary.density_pT_Soave #3

thorade opened this issue Nov 20, 2012 · 4 comments

Comments

@thorade
Copy link
Owner

thorade commented Nov 20, 2012

For Pentane at p=1e-6 and T=578.275 the Soave algorithm goes to the supercritical branch, where three roots exist. According to Span, two of the three roots result in negative densities, but in this case this is not true.
Not a big problem, as this is used as starting value only, but it slows down the pT iteration.

Also, the RKS EoS should be able to correctly describe the liquid region, at least qualitatively.

@ghost ghost assigned thorade Nov 20, 2012
thorade added a commit that referenced this issue Nov 20, 2012
@thorade
Copy link
Owner Author

thorade commented Nov 20, 2012

see Span 2000, page 48-51
http://books.google.de/books?id=dd410GGw8wUC&pg=PA48

@thorade
Copy link
Owner Author

thorade commented Dec 5, 2012

There is a section about solving cubic equations in
"Thermodynamics - Fundamentals for Applications" by O'Connell and Haile
(see Appendix C, page 620):
http://www.cambridge.org/9780521582063
http://books.google.de/books?id=1rOA5I6kQ7gC&&pg=PA620

thorade added a commit that referenced this issue Sep 25, 2013
@thorade
Copy link
Owner Author

thorade commented Apr 1, 2014

Also see paper by Deiters 2014:
http://dx.doi.org/10.1021/ie4038664
And the WP articles on (solving) cubic functions:
https://en.wikipedia.org/wiki/Cubic_function

@thorade thorade removed their assignment Nov 30, 2015
@thorade
Copy link
Owner Author

thorade commented Jun 5, 2021

Also read the references cited in this blog post:
http://momentsingraphics.de/CubicRoots.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant