Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convergence of setSat functions very close to critical point #16

Closed
thorade opened this issue May 2, 2013 · 4 comments
Closed

convergence of setSat functions very close to critical point #16

thorade opened this issue May 2, 2013 · 4 comments

Comments

@thorade
Copy link
Owner

thorade commented May 2, 2013

Very close to the critical point (e.g. T_crit-0.1 or T_crit-1e-6) the setSat functions may fail. This will happen only for fluids where only few data were available for fitting the EoS and the ancillary equations, one example is HDMS.

@thorade
Copy link
Owner Author

thorade commented May 27, 2013

Tested convergence of setSat_T, setSat_p and setSat_d with 10000 points each,
tested HMDS, Ethanol, Isopentane, R134a, Propane, Butane, Helium.
All algorithms converged for all fluids, closing this issue.

@thorade thorade closed this as completed May 27, 2013
@thorade
Copy link
Owner Author

thorade commented May 28, 2013

With HDMS, Akasaka does find a solution, but it is a wrong one!
Check sat.liq.d, it is lower than critical density.

@thorade thorade reopened this May 28, 2013
thorade added a commit that referenced this issue May 28, 2013
thorade added a commit that referenced this issue May 28, 2013
(although it should do exactly the same as the manual solution)
@thorade thorade closed this as completed May 28, 2013
@thorade
Copy link
Owner Author

thorade commented Dec 11, 2020

new convergence ticket: #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant