Bug fix: Bot move freezes player move

[LucaSain]

Fix for player move freeze by bot move computation

Description

On each game tick, the bot move state will be checked and the player move will be rendered first.

This solution relies on a variable exposed through the board enum and an if clause in the app loop. This solution is not perfect and maybe a thread-event approach would be better. Any feedback would be extremely helpful.

Fixes #83

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[thomas-mauran]

Hello @LucaSain thanks for the contribution the code seems good and logical, do you have any steps to reproduce the bug ? I wasn't able to reproduce it on my computer

[LucaSain]

Hi, sorry for late reply.

Hello @LucaSain thanks for the contribution the code seems good and logical, do you have any steps to reproduce the bug ? I wasn't able to reproduce it on my computer

Try with this bot. It's slower and the issue should visible:
https://github.com/LucaSain/chess-daniel

[thomas-mauran]

Hi, sorry for late reply.

Hello @LucaSain thanks for the contribution the code seems good and logical, do you have any steps to reproduce the bug ? I wasn't able to reproduce it on my computer

Try with this bot. It's slower and the issue should visible: https://github.com/LucaSain/chess-daniel

Ah yes I do see it now, I tried to play a game and lost but the game didn't end after reading the code maybe this is an edge case, I was able to get the Black Won text after selecting the black queen in this position:

[thomas-mauran]

Hi @LucaSain wanting to know if you will finish this issue or if I shall do it ?

[LucaSain]

Hi @LucaSain wanting to know if you will finish this issue or if I shall do it ?

Working on it right now. I'll try to finish it by tomorrow.

[LucaSain]

This should do, however this still feels like a workaround. Should I create a new method or move the checkmate and draft check from the if clause to the switch_turn method?

[thomas-mauran]

This should do, however this still feels like a workaround. Should I create a new method or move the checkmate and draft check from the if clause to the switch_turn method?

This will do the trick for now, I am working on a refactor so this will probably be part of it. Thanks for your contribution ! 🎉