Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Images seem to get re-rendered on state change #13

Open
daaain opened this issue Jul 26, 2015 · 0 comments
Open

Images seem to get re-rendered on state change #13

daaain opened this issue Jul 26, 2015 · 0 comments

Comments

@daaain
Copy link

daaain commented Jul 26, 2015

We have started using Imager.jsx and our implementation is in very early stages in terms of responsive images in general, but we started seeing some performance issues on state changes.

Haven't quite managed to get to the heart of the issue and there's also some heavy TransitionManager usage in place, but replacing Imager.jsx with static <img>s improved things.

I noticed that there's no shouldComponentUpdate implemented so maybe it could be fixed relatively simply?

I know this is all a bit vague, but just wanted to see what you think before digging deep into Imager code.

Actually one question, is there any specific trick to make sure that the React components created by the Imager.jsx factory get properly reused?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant