Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollectionManager - Consider removing default pagination from createCollectionManager #197

Open
3 tasks
lakardion opened this issue Jul 2, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@lakardion
Copy link
Member

lakardion commented Jul 2, 2024

From internal conversation @oudeismetis and for the sake of making the createCollectionManager as consistent as possible with the current list method implementation of tn-models. We should consider removing the default pagination value for the collection manager.

See here:

export const createCollectionManager = <TFetchList extends FilterFn>({
fetchList,
list: feedList,
filters,
pagination: feedPagination = Pagination.create(),

We can just remove this pagination default and expect it to be undefined and avoid passing default pagination filters

Checklist

  • Remove default pagination from createCollectionManager
  • Handle undefined pagination within the collection manager
  • Document this change
@lakardion lakardion added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant