Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Use pull-request for new commits #26

Open
csukuangfj opened this issue Oct 20, 2024 · 2 comments
Open

[Feature request]: Use pull-request for new commits #26

csukuangfj opened this issue Oct 20, 2024 · 2 comments
Labels
feature New feature or request

Comments

@csukuangfj
Copy link

I suggest that new commits be merged via pull request, not directly pushing them to the master branch.

Users watching this repo will get notified of new changes if a pull request is used. Also, it is easier to review
the changes and leave comments.

@thewh1teagle
Copy link
Owner

@csukuangfj

Sometimes I push small changes straight to main. I'll try to make pull requests for any additions or fixes from now on.

@ghjdegithub
Copy link
Contributor

I suggest that new commits be merged via pull request, not directly pushing them to the master branch.我建议通过拉取请求合并新提交,而不是直接将它们推送到主分支。

Users watching this repo will get notified of new changes if a pull request is used. Also, it is easier to review如果使用拉取请求,观看此存储库的用户将收到新更改的通知。另外,审核也比较容易 the changes and leave comments.更改并留下评论。

I suggest that new commits be merged via pull request, not directly pushing them to the master branch.我建议通过拉取请求合并新提交,而不是直接将它们推送到主分支。

Users watching this repo will get notified of new changes if a pull request is used. Also, it is easier to review如果使用拉取请求,观看此存储库的用户将收到新更改的通知。另外,审核也比较容易 the changes and leave comments.更改并留下评论。

你也要搞Rust吗?

@thewh1teagle thewh1teagle added the feature New feature or request label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants