Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libtool, fix Mac library issues #86

Open
ryandesign opened this issue Aug 26, 2018 · 1 comment
Open

Use libtool, fix Mac library issues #86

ryandesign opened this issue Aug 26, 2018 · 1 comment

Comments

@ryandesign
Copy link
Contributor

Hi, I'm the maintainer of stk in MacPorts. I've been meaning for years to report to you that there are several issues with the way your library is being created: it doesn't have an install_name set; it doesn't have versioning information set; its filename is unusual; your library versioning scheme may be incorrect or nonexistent. When I updated MacPorts stk to 4.5.0 I added patches to fix it well enough for our use, but your code has changed in the meantime.

It looks like @rdpoor has beaten me to it and reported some of this in #28 and #40 but no solutions seem to have been committed yet and those issues were closed.

The problems seem to stem from the fact that you generate shared libraries manually. Generating shared libraries accurately is apparently a complex topic. I could tell you all about how to make shared libraries on the Mac, but I have only a theoretical understanding of them on other systems. I could try to update my patches and submit PRs to you, but I'm not confident that I would make the best choices for everyone.

If you used libtool to generate the shared libraries, it would know the right thing to do on every operating system. Is there a reason why you don't use it here?

@garyscavone
Copy link
Contributor

Honestly, I don't understand all the naming issues and the proper way to deal with them (my main interest in STK is the functionality of the code itself, not the packaging). If someone wants to submit a PR that addresses the issue, we can consider it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants