Should install rawwaves and set RAWWAVE_PATH accordingly

[yurivict]

Currently, build receives this argument -DRAWWAVE_PATH=\"../../rawwaves/\"

Since rawwaves are needed in the runtime, it should be installed (under share/).

[radarsat1]

Although this may change with #70, in the meantime, I can agree here I think.

[garyscavone]

The path mentioned above is correct, at least for the default "non-install" builds. If someone wants to compile and install STK as might be expected for "make install," then the rawwave files could be moved elsewhere and the above mentioned definition would need to be updated accordingly. As menionted, #70 might be a better approach. So, if anyone attempts to make changes to the build system, make sure it doesn't break the default "non-install" case.

[yurivict]

I have a question: I am building the stk FreeBSD ports for various FreeBSD versions. The rawwaves/ folder on some OS versions has dotted files, ex. rawwaves/._mand3.raw, and on some other versions it doesn't have such files. Are these files needed during the run-time?

Those dotted files also contain strings Mac OS X and com.apple.quarantine^@q/0081;59a8c0e3;Safari.app; which seem wrong to me.

[garyscavone]

I don't see these dot files in the github repo. Where have you found them? Generally, there should not be any rawwave files that start with a dot.

[yurivict]

They are left in the rawwaves/ after the build is done. Please see below the partial list of them

rawwaves/._ahh.raw
rawwaves/._bassdrum.raw
rawwaves/._britestk.raw
rawwaves/._cowbell1.raw
rawwaves/._crashcym.raw
rawwaves/._dope.raw
rawwaves/._eee.raw
rawwaves/._fwavblnk.raw
rawwaves/._halfwave.raw
rawwaves/._hihatcym.raw
rawwaves/._impuls10.raw
rawwaves/._impuls20.raw
rawwaves/._impuls40.raw
rawwaves/._makefunc.c
rawwaves/._makemidi.c
rawwaves/._makewavs.c
rawwaves/._mand1.raw
rawwaves/._mand10.raw
rawwaves/._mand11.raw
rawwaves/._mand12.raw
rawwaves/._mand2.raw
rawwaves/._mand3.raw
rawwaves/._mand4.raw
rawwaves/._mand5.raw
rawwaves/._mand6.raw
rawwaves/._mand7.raw
rawwaves/._mand8.raw
rawwaves/._mand9.raw
rawwaves/._mandpluk.raw
rawwaves/._marmstk1.raw
rawwaves/._ooo.raw
rawwaves/._peksblnk.raw
rawwaves/._ppksblnk.raw
rawwaves/._ridecymb.raw
rawwaves/._silence.raw
rawwaves/._sine.c
rawwaves/._sineblnk.raw
rawwaves/._sinewave.raw
rawwaves/._snardrum.raw
rawwaves/._snglpeak.raw
rawwaves/._tambourn.raw
rawwaves/._tomhidrm.raw
rawwaves/._tomlowdr.raw
rawwaves/._tommiddr.raw
rawwaves/._twopeaks.raw

The FreeBSD port installs rawwaves/ with its contents because the port has to be self-contained. And this problem with file list variability came up on some builds.

[yurivict]

Version 4.6.0

[garyscavone]

I just tried on OS-X and I don't get those files after a build, so it seems like a system / compiler issue. I'm on the road and will only have access to OS-X for the next year.

[yurivict]

Ok, thanks, so I believe that the best way is to delete them then.

[radarsat1]

Those ._ files are created by OS X Finder to store metadata. Just ignore them or delete them.

As for the subject at hand, with automake this situation is handled by EXTRA_DIST. A place to install extra files would be /usr/share/stk. ($datadir in automake)

I notice that the default for the demo projects is to use ../../rawwaves as the default value, but I notice this is in the header file as well as in the configure files. Perhaps this can be reconciled.. I'll try to come up with a proposal. I think perhaps the installed library should default to the install prefix absolute path, while the demo projects (which are not installed?) should override this to point at the relative path (../../rawwaves). Something like that.