Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #35

Open
dophire opened this issue Sep 9, 2023 · 10 comments
Open

[BUG] #35

dophire opened this issue Sep 9, 2023 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@dophire
Copy link

dophire commented Sep 9, 2023

I'm using Vanadium mod for custom colors since Colormatic hasn't been updated to 1.20.1 and I'm using Bedrock Waters color resourcepack. Everything works perfectly until I fill a cauldron with water and then the game crashes when trying to render it. It seems like it is caused by the fact that Sodium added "Cauldron blocks no longer force the use of smooth biome color blending for the fluid contents." to 0.5.2.

Reproduction Steps
Use the latest Sodium + Indium + Vanadium. Use a resource pack that changes the water colors. Place a cauldron and fill it with water, and the game will crash.
crash-2023-09-08_22.22.23-client.txt

Expected behavior
The water-filled cauldron will render properly and won't crash the game.

Desktop

  • OS: [Windows]
  • Minecraft Version [1.20.1]
  • Mod Version [0.1.625]
@dophire dophire added the bug Something isn't working label Sep 9, 2023
@AluTheCrow
Copy link
Member

I'm unable to reproduce this with Sodium, Indium, and Vanadium only.

However, I can reproduce this with Continuity.
Reviewing this further

@dophire
Copy link
Author

dophire commented Sep 11, 2023

I see! Thank you! I assumed it was indium/sodium because it was stated as an Indium Render error, but continuity does make sense!

@AluTheCrow
Copy link
Member

No worries!
I really appreciate you bringing this up, I'll try and work on a solution from my end, but I'm not sure how successful I'll be - would you mind poking around on the Continuity github or discord and see if there's an issue too?

@dophire
Copy link
Author

dophire commented Sep 11, 2023

I'll see what I can do!

@dophire
Copy link
Author

dophire commented Sep 11, 2023

This is the closest thing I found to our issue PepperCode1/Continuity#273

@AluTheCrow
Copy link
Member

Update - I think I have the fix for this, and should be released this weekend with 0.1.7

@dophire
Copy link
Author

dophire commented Sep 17, 2023

Ayyy, great to hear! Thanks!

@sasquott
Copy link

sasquott commented Oct 1, 2023

New test build of Continuity (3.0 beta4) for 1.20.2 is available in test builds, Peppers Discord, Vanadium no longer crashes with Continuity running, but also does not work as intended, looking forward to seeing 0.1.7 soon? (Vanadium 0.1.625 works fine in 1.20.2 without Continuity running btw)

@AluTheCrow
Copy link
Member

I believe I've figured out more of the registry issue - so at least in vanilla it works, with continuity and Athena.
Going to try for Modded biomes.

@dophire
Copy link
Author

dophire commented Oct 3, 2023

Yay! Any info on when the new version will be released by any chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants