Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting algo #11

Open
vaibhavchellani opened this issue Sep 16, 2020 · 2 comments · Fixed by #61
Open

Fix sorting algo #11

vaibhavchellani opened this issue Sep 16, 2020 · 2 comments · Fixed by #61
Assignees
@ChihChengLiang

Comments

@vaibhavchellani
Copy link
Contributor

Fix the sorting algorithm to sort the transactions by nonce and fees
@ChihChengLiang ChihChengLiang self-assigned this Nov 2, 2020
@ChihChengLiang
Copy link
Collaborator

On this

@ChihChengLiang
Copy link
Collaborator

Posting our offline chat:

Changes needed in: https://github.com/thehubbleproject/hubble-commander/blob/master/core/tx.go#L96
The logic here at the moment is broken at many level TBH: https://github.com/thehubbleproject/hubble-commander/blob/master/core/tx.go#L96-L125

  • for example it uses LIMIT which means if there 2 transactions of type 1 in DB before 4 txs of type 2 it will pick up 2 transactions
  • coordinator will push wrong batch if the sender sends txs in non-ascending order

@ChihChengLiang ChihChengLiang linked a pull request Nov 17, 2020 that will close this issue
add popTxs test #61
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChihChengLiang ChihChengLiang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add popTxs test thehubbleproject/hubble-commander
2 participants
@ChihChengLiang @vaibhavchellani