Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split BlsSignerFactory.getSigner into direct Fr input and arbitrary seed #30

Open
jacque006 opened this issue Mar 15, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jacque006
Copy link
Contributor

Problem

Per #28 (comment) , BlsSignerFactory.getSigner is not explicit in whether it will hash or directly set the provided secret. This could create compatibility issues with other BLS libs and does not give the consumer a way to know how their secret will be used in signing.

Solution

Split BlsSignerFactory.getSigner into two factory methods:

  • BlsSignerFactory.getSigner, which will directly set the provided Fr and throw if it out of range.
  • BlsSignerFactory.getSignerHashed, which will hash the provided secret/seed.
@jacque006 jacque006 added the enhancement New feature or request label Mar 15, 2022
@jacque006 jacque006 changed the title Split BlsSignerFactory.getSigner into direct Fr input and aritrary seed Split BlsSignerFactory.getSigner into direct Fr input and arbitrary seed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant