You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per #28 (comment) , BlsSignerFactory.getSigner is not explicit in whether it will hash or directly set the provided secret. This could create compatibility issues with other BLS libs and does not give the consumer a way to know how their secret will be used in signing.
Solution
Split BlsSignerFactory.getSigner into two factory methods:
BlsSignerFactory.getSigner, which will directly set the provided Fr and throw if it out of range.
BlsSignerFactory.getSignerHashed, which will hash the provided secret/seed.
The text was updated successfully, but these errors were encountered:
jacque006
changed the title
Split BlsSignerFactory.getSigner into direct Fr input and aritrary seed
Split BlsSignerFactory.getSigner into direct Fr input and arbitrary seed
Mar 15, 2022
Problem
Per #28 (comment) ,
BlsSignerFactory.getSigner
is not explicit in whether it will hash or directly set the provided secret. This could create compatibility issues with other BLS libs and does not give the consumer a way to know how their secret will be used in signing.Solution
Split
BlsSignerFactory.getSigner
into two factory methods:BlsSignerFactory.getSigner
, which will directly set the provided Fr and throw if it out of range.BlsSignerFactory.getSignerHashed
, which will hash the provided secret/seed.The text was updated successfully, but these errors were encountered: