-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sync of deps of Ansible collections optional #3480
Open
maximiliankolb
wants to merge
1
commit into
theforeman:master
Choose a base branch
from
ATIX-AG:ansible_collections_dependencies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make sync of deps of Ansible collections optional #3480
maximiliankolb
wants to merge
1
commit into
theforeman:master
from
ATIX-AG:ansible_collections_dependencies
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thorben-D
suggested changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion. Other than that, looks good!
guides/common/modules/proc_synchronizing-ansible-collections.adoc
Outdated
Show resolved
Hide resolved
pr-processor
bot
added
Waiting on contributor
Requires an action from the author
and removed
Not yet reviewed
labels
Nov 29, 2024
Users can now opt-out of synchronizing dependencies of Ansible collections to Foreman+Katello. Refs redmine 37958 Refs 58dfb8cac9fed8bd868338391900a801c947ba0e in katello
maximiliankolb
force-pushed
the
ansible_collections_dependencies
branch
from
November 29, 2024 07:27
f734874
to
b4341ce
Compare
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
Requires an action from the author
Needs re-review
labels
Nov 29, 2024
maximiliankolb
added
tech review done
No issues from the technical perspective
Needs style review
Requires a review from docs style/grammar perspective
labels
Nov 29, 2024
sbernhard
approved these changes
Nov 29, 2024
Thorben-D
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs style review
Requires a review from docs style/grammar perspective
tech review done
No issues from the technical perspective
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Users can now opt-out of synchronizing dependencies of Ansible collections to Foreman+Katello.
Refs redmine 37958
Refs 58dfb8cac9fed8bd868338391900a801c947ba0e in katello
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
new option in Foreman+Katello nightly
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: