Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review exception handling in transport command #36

Open
netsensei opened this issue Jun 5, 2017 · 2 comments
Open

Review exception handling in transport command #36

netsensei opened this issue Jun 5, 2017 · 2 comments

Comments

@netsensei
Copy link
Contributor

The Datahub::Factory::Command::transport module currently contains several nested try...catch blocks, including different ways in which errors are caught, processed or bubble up to an ancestor catch.

@netsensei
Copy link
Contributor Author

Todo:

  • Add extra exception classes in an Error.pm module.
  • Review the try catch blocks we have right now throughout the app.
  • Review how errors are logged throughout the app. Bubble up exceptions to the least amount of catch blocks we can get away with, instead of spreading catch blocks throughout the app.

@netsensei
Copy link
Contributor Author

  • When an error bubbles up, always mention the ID of the breaking record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant