You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, all fixers (Datahub::Factory::Fixer and children) have the attribute fixer, which in itself has the method fix that is used to execute the Fix. It would be cleaner and more in line with the rest of the application if Datahub::Factory::Fixer and children have the method fix, so we can replace
$fixer->fixer->fix($item);
with
$fixer->fix($item);
The text was updated successfully, but these errors were encountered:
Thanks for offering to help! The solution to this problem is, I think, twofold:
Update Fix.pm to expose the method ->fix() of the fixer attribute. See Datahub.pm for an example. For more information on how fixes work, see Catmandu::Fix.
Update transport.pm so it uses ->fix() instead of ->fixer->fix().
You can simply clone the master branch (we have no dev branch) and open a pull request.
Should you have any more questions, don't hesitate to ask them.
Currently, all fixers (
Datahub::Factory::Fixer
and children) have the attributefixer
, which in itself has the methodfix
that is used to execute the Fix. It would be cleaner and more in line with the rest of the application ifDatahub::Factory::Fixer
and children have the methodfix
, so we can replacewith
The text was updated successfully, but these errors were encountered: