Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Datahub::Factory::Fixer, replace ->fixer->fix with ->fix #27

Open
pieterdp opened this issue May 11, 2017 · 3 comments
Open

In Datahub::Factory::Fixer, replace ->fixer->fix with ->fix #27

pieterdp opened this issue May 11, 2017 · 3 comments

Comments

@pieterdp
Copy link
Contributor

Currently, all fixers (Datahub::Factory::Fixer and children) have the attribute fixer, which in itself has the method fix that is used to execute the Fix. It would be cleaner and more in line with the rest of the application if Datahub::Factory::Fixer and children have the method fix, so we can replace

$fixer->fixer->fix($item);

with

$fixer->fix($item);
@morrme
Copy link

morrme commented May 15, 2017

I'd like to help.

@pieterdp
Copy link
Contributor Author

Hi,

Thanks for offering to help! The solution to this problem is, I think, twofold:

  • Update Fix.pm to expose the method ->fix() of the fixer attribute. See Datahub.pm for an example. For more information on how fixes work, see Catmandu::Fix.
  • Update transport.pm so it uses ->fix() instead of ->fixer->fix().

You can simply clone the master branch (we have no dev branch) and open a pull request.

Should you have any more questions, don't hesitate to ask them.

@morrme
Copy link

morrme commented Jun 2, 2017

I need to wrap this up ....will update soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants