Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog Admin Feature: Add Images by URL #191

Closed
joebew42 opened this issue Jan 29, 2018 · 0 comments
Closed

Changelog Admin Feature: Add Images by URL #191

joebew42 opened this issue Jan 29, 2018 · 0 comments

Comments

@joebew42
Copy link
Contributor

Description

Many objects in Changelog's system have attachable images. People have avatars. Sponsors have logos. Topics have icons. Etc.

Currently, we attach images by downloading them to our machines and then uploading them via a file input on the forms. An example form:

This is fine, but many times the images already exist on the web somewhere.

We want to augment these forms to optionally accept an image URL instead of an image file. If a URL is provided, its image will be fetched and used just as if it was uploaded via the file input. All image processing/transformation should continue to work like normal.

Notes

  • Our file attachments rely upon the excellent Arc (and Arc Ecto) libraries.
  • This Arc issue has some discussion on how the library can be used in such a manner
  • All Arc-related modules use Changelog.file, so it's a good place for shared functionality
  • Modules with image attachments: Person, Sponsor, Topic, NewsItem, NewsSource, NewsAd
  • A basic implementation on one module/form which can be generalized to other scenarios would be a great start
joebew42 added a commit to joebew42/changelog.com that referenced this issue Jan 29, 2018
joebew42 added a commit to joebew42/changelog.com that referenced this issue Jan 31, 2018
    This commit will add the support to upload the avatar
    of a person by providing the image URL.
    That feature is available from the admin website.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant